Re: [PATCH] git-cherry.txt: Change symbol marks in graph.
- From
Michael J Gruber <git@drmicha.warpmail.net>
- Date
- Dec 2, 2010, 11:05 UTC
- Message-ID
- <4CF77D7D.90507@drmicha.warpmail.net>
- In-Reply-To
- <m31v604nc0.fsf@localhost.localdomain>
Jakub Narebski venit, vidit, dixit 02.12.2010 09:00:
Show 15 quoted lines
> Jari Aalto <jari.aalto@cante.net> writes:
>
>> From: Jari Aalto <jari.aalto@cante.net>
>>
>> The common commit were marked with a minus sign (-), but that is
>> usually interpreted as something less or substracted. Use natural
>> equal sign (=). Commits that are not in upstream were marked with plus
>> sign (+) but a question mark (?) is visually a litle more striking
>> (erect) in context where all other signs are "flat". It also helps
>> visually impared to see difference between (* ... ?) as opposed to
>> similar signs (* ... +).
>
> Reading comprehension FAIL. The graph in question uses '+' and '-' because
> that is what 'git cherry' *output( uses ('+' included, '-' excluded). They
> are very natural in git-cherry output (diff-like).Yep, and I so wished that git-cherry had different output that I even saw a git-cherry patch where there was none...
So, +1 from me if this comes with an actual code patch.
Michael