Re: bug: "fatal: cannot pread pack file", version 1.7.5.4

From: Andreas Schwab <schwab@linux-m68k.org>
Date: Jul 2, 2012, 22:43 UTC
Message-ID: <m2vci5n5r5.fsf@igel.home>
In-Reply-To: <20120702215736.GA5790@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> It's very odd for pread to report ENOENT (since it is always operating
> on an already-opened file descriptor).

It doesn't, but gettext will clobber errno:

		n = pread(pack_fd, inbuf, n, from);
		if (n < 0)
			die_errno(_("cannot pread pack file"));

There is nothing that saves errno. This isn't limited to i18n though, any function call in the arguments may potentially clobber errno.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."