Re: bug: "fatal: cannot pread pack file", version 1.7.5.4

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 2, 2012, 23:50 UTC
Message-ID: <7v1uktyb7n.fsf@alter.siamese.dyndns.org>
In-Reply-To: <m2vci5n5r5.fsf@igel.home>

Andreas Schwab <schwab@linux-m68k.org> writes:

Show 13 quoted lines

> Jeff King <peff@peff.net> writes:
>
>> It's very odd for pread to report ENOENT (since it is always operating
>> on an already-opened file descriptor).
>
> It doesn't, but gettext will clobber errno:
>
> 		n = pread(pack_fd, inbuf, n, from);
> 		if (n < 0)
> 			die_errno(_("cannot pread pack file"));
>
> There is nothing that saves errno.  This isn't limited to i18n though,
> any function call in the arguments may potentially clobber errno.

Argh...