Re: [PATCH] Makefile: avoid a fork in Cygwin version check

From: Andreas Schwab <schwab@linux-m68k.org>
Date: Apr 5, 2010, 15:36 UTC
Message-ID: <m2eiitc3n3.fsf@igel.home>
In-Reply-To: <20100405151059.GB13761@progeny.tock>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 10 quoted lines

> diff --git a/Makefile b/Makefile
> index e210a42..767fb66 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -831,7 +831,7 @@ ifeq ($(uname_S),SunOS)
>  	BASIC_CFLAGS += -D__EXTENSIONS__ -D__sun__ -DHAVE_ALLOCA_H
>  endif
>  ifeq ($(uname_O),Cygwin)
> -	ifeq ($(shell expr "$(uname_R)" : '1\.[1-6]\.'),4)
> +	ifeq ($(shell case '$(uname_R)' in (1.[1-6].*) echo old;; esac),old)

Even less forks:

        ifneq ($(filter 1.1.% 1.2.% 1.3.% 1.4.% 1.5.% 1.6.%,$(uname_R)),)

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."