Re: [PATCH] Makefile: update defaults for modern Cygwin

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 2, 2010, 06:47 UTC
Message-ID: <7vaatmmju9.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1270161834-9597-1-git-send-email-eblake@redhat.com>

Eric Blake <eblake@redhat.com> writes:

Show 13 quoted lines

> Now that Cygwin 1.7.x has enabled lots of new features, and Cygwin 1.5
> is no longer actively supported by the Cygwin mailing lists, we might
> as well update the defaults to cater to those new features.
>
> NO_TRUSTABLE_FILEMODE is only necessary on FAT drives; the Cygwin
> community recommends NTFS drives, but there is still too much use
> for FAT to switch the default.  Likewise, UNRELIABLE_FSTAT is probably
> file-system specific, but worth keeping unchanged.
>
> This commit does not change the default for NO_MMAP, although definitive
> proof of whether this option is necessary is lacking.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>

Thanks; as I lack Cygwin environment to test this myself, I'll apply this directly on 'master' and see if anybody screams ;-)

> +	ifneq ($(wordlist 1, 2, $(subst ., ,$(uname_R))),1 7)

Do we need to update this part when Cygwin 1.8 is released? Replacing this with "ifeq(... ,1 5)" may not be an improvement either, unless we are sure that nobody is using 1.4 or older, but I wonder if somebody else have better ideas?