Re: Trial git RPM's..

From: Eric W. Biederman <ebiederm@xmission.com>
Date: Jul 12, 2005, 00:55 UTC
Message-ID: <m1vf3gzvvd.fsf@ebiederm.dsl.xmission.com>
In-Reply-To: <Pine.LNX.4.58.0507110958400.17536@g5.osdl.org>

Linus Torvalds <torvalds@osdl.org> writes:

Show 9 quoted lines

> On Mon, 11 Jul 2005, Eric W. Biederman wrote:
>
>> Are you still up for a patch that records who and when made a tag?
>> I sent one but it seems to have been lost.
>
> I'd really actually prefer for the code to be shared with the commit code, 
> so that the user info (name, email, date) would not just be exactly the 
> same, but would share the same code so that we don't end up having them 
> ever get out of sync.

Sounds fair.

> That would imply moving parts of "git-tag-script" into mktag.c.

Actually I was looking at doing a git-ident thing that will just compute who git thinks you are. And then git-commit-tree can just popen it to share code. That looks like how the logic has been accomplished in other places.

Moving parts of git-tag-script into mktag is hard because you have to generate a flat file to pass to gpg. And I don't think I am ready to hard code the call to gpg into mktag, as some other signing method may come along. Although that may be the saner choice.

Anyway the git-ident thing is easy and informative for debugging so I will finish coding that up as soon as I get home.

Eric