git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Trial git RPM's..

From
CWChris Wright <chrisw@osdl.org>
Date
Jul 11, 2005, 21:03 UTC
Message-ID
<20050711210309.GT5324@shell0.pdx.osdl.net>
In-Reply-To
<Pine.LNX.4.58.0507110958400.17536@g5.osdl.org>
* Linus Torvalds (torvalds@osdl.org) wrote:
Show 11 quoted lines
> On Mon, 11 Jul 2005, Eric W. Biederman wrote:
> > 
> > A couple of pieces.  The dist target has assumes git-tar-tree is in the
> > path.  Making it so you have to have git installed to build the rpm.
> 
> Yes. Maybe we could relax that requirement by using "./git-tar-tree" or 
> something? That still requires that you have _built_ git to do the rpm, 
> but at least you won't have had to install it.
> 
> Does that fit the rpm build process? Or does an rpm build make something 
> like that really inconvenient? I don't know, patches welcome.

No, that could be done. It's not the rpmbuild at that point, it's just prepping to do the rpmbuild. It's only an issue for those that are trying to build an rpm directly from the git source and who've never installed git before. Doesn't seem necessary to me, I'm not that fond of it (will even slightly slow down make dist process if it's done from a clean, i.e. make clean, dir), but hey...the trivial patch below does this.

Show 7 quoted lines
> > And it does not pass my torture test of building rpm's on debian,
> > but that is not a huge problem.
> 
> Ok, why is debian problematic? Is there some missing dependency or 
> something? I really haven't ever done an rpm, and the git rpm target was 
> all done by Chris Wright, so I don't have any clue at all. Again, patches 
> welcome.

Heh debian rpm build...I missed that bit in Eric's message. Eric, care to give details?

thanks, -chris --

Use git-tar-tree directly from git source during make dist. This handles bootstrap issue with git not being installed.

Signed-off-by: Chris Wright <chrisw@osdl.org>
---
diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -175,8 +175,8 @@ git.spec: git.spec.in
 	sed -e 's/@@VERSION@@/$(GIT_VERSION)/g' < $< > $@
 
 GIT_TARNAME=git-$(GIT_VERSION)
-dist: git.spec
-	git-tar-tree HEAD $(GIT_TARNAME) > $(GIT_TARNAME).tar
+dist: git.spec git-tar-tree
+	./git-tar-tree HEAD $(GIT_TARNAME) > $(GIT_TARNAME).tar
 	@mkdir -p $(GIT_TARNAME)
 	@cp git.spec $(GIT_TARNAME)
 	tar rf $(GIT_TARNAME).tar $(GIT_TARNAME)/git.spec
Previous: Linus TorvaldsNext: Eric W. Biederman
Message 4 of 25 in “Trial git RPM's..”
  1. Linus TorvaldsJul 11, 2005
  2. Eric W. BiedermanJul 11, 2005
  3. Linus TorvaldsJul 11, 2005
  4. Chris WrightJul 11, 2005
  5. Eric W. BiedermanJul 12, 2005
  6. Linus TorvaldsJul 12, 2005
  7. Eric W. BiedermanJul 12, 2005
  8. Linus TorvaldsJul 12, 2005
  9. Chris WrightJul 12, 2005
  10. Eric W. BiedermanJul 12, 2005
  11. Linus TorvaldsJul 12, 2005
  12. Eric W. BiedermanJul 12, 2005
  13. tagger idEric W. Biederman, Jul 12, 2005
  14. Eric W. BiedermanJul 12, 2005
  15. Junio C HamanoJul 12, 2005
  16. Eric W. BiedermanJul 12, 2005
  17. Petr BaudisJul 12, 2005
  18. Junio C HamanoJul 12, 2005
  19. Eric W. BiedermanJul 15, 2005
  20. Linus TorvaldsJul 12, 2005
  21. Eric W. BiedermanJul 12, 2005
  22. Junio C HamanoJul 12, 2005
  23. Eric W. BiedermanJul 15, 2005
  24. Eric W. BiedermanJul 12, 2005
  25. Chris WrightJul 11, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.