git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/6] In handle_body only read a line if we don't already have one.

From
Eric W. Biederman <ebiederm@xmission.com>
Date
May 23, 2006, 19:49 UTC
Message-ID
<m1r72kiksz.fsf_-_@ebiederm.dsl.xmission.com>
In-Reply-To
<m1verwikvj.fsf_-_@ebiederm.dsl.xmission.com>

This prepares for detecting non-email patches that don't have mail headers. In which case we have already read the first line so handle_body should not ignore it.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
 mailinfo.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
3ad0c255a351d771c7f301d4a4e9bfb6fdcbde5f
diff --git a/mailinfo.c b/mailinfo.c
index 3fa9505..99989c2 100644
--- a/mailinfo.c
+++ b/mailinfo.c
@@ -724,7 +724,7 @@ static void handle_body(void)
 {
 	int seen = 0;
 
-	if (fgets(line, sizeof(line), stdin) != NULL) {
+	if (line[0] || fgets(line, sizeof(line), stdin) != NULL) {
 		handle_commit_msg(&seen);
 		handle_patch();
 	}
-- 
1.3.2.g5041c-dirty
Previous: Eric W. BiedermanNext: Eric W. Biederman
Message 5 of 10 in “Detect non email patches in git-mailinfo”
  1. 0/6 Detect non email patches in git-mailinfoEric W. Biederman, May 23, 2006
  2. 1/6 Make read_one_header_line return a flag not a length.Eric W. Biederman, May 23, 2006
  3. 2/6 Move B and Q decoding into check header.Eric W. Biederman, May 23, 2006
  4. 3/6 Refactor commit messge handling.Eric W. Biederman, May 23, 2006
  5. 4/6 In handle_body only read a line if we don't already have one.Eric W. Biederman, May 23, 2006
  6. 5/6 More accurately detect header lines in read_one_header_lineEric W. Biederman, May 23, 2006
  7. 6/6 Allow in body headers beyond the in body header prefix.Eric W. Biederman, May 23, 2006
  8. Junio C HamanoMay 26, 2006
  9. Junio C HamanoMay 23, 2006
  10. Eric W. BiedermanMay 26, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.