git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/6] Allow in body headers beyond the in body header prefix.

From
Eric W. Biederman <ebiederm@xmission.com>
Date
May 23, 2006, 19:58 UTC
Message-ID
<m1irnwikcz.fsf_-_@ebiederm.dsl.xmission.com>
In-Reply-To
<m1mzd8iklr.fsf_-_@ebiederm.dsl.xmission.com>
- handle_from is fixed to not mangle it's input line.
- Then handle_inbody_header is allowed to look in
  the body of a commit message for additional headers
  that we haven't already seen.

This allows patches with all of the right information in unfortunate places to be imported.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
 mailinfo.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)
eca59d2fd60af47170cdbfdebf3384465f0e7635
diff --git a/mailinfo.c b/mailinfo.c
index c642ff4..99374b3 100644
--- a/mailinfo.c
+++ b/mailinfo.c
@@ -72,11 +72,14 @@ static int bogus_from(char *line)
 	return 1;
 }
 
-static int handle_from(char *line)
+static int handle_from(char *in_line)
 {
-	char *at = strchr(line, '@');
+	char line[1000];
+	char *at;
 	char *dst;
 
+	strcpy(line, in_line);
+	at = strchr(line, '@');
 	if (!at)
 		return bogus_from(line);
 
@@ -242,8 +245,6 @@ #define SEEN_PREFIX  0x08
 /* First lines of body can have From:, Date:, and Subject: */
 static void handle_inbody_header(int *seen, char *line)
 {
-	if (*seen & SEEN_PREFIX)
-		return;
 	if (!memcmp("From:", line, 5) && isspace(line[5])) {
 		if (!(*seen & SEEN_FROM) && handle_from(line+6)) {
 			*seen |= SEEN_FROM;
-- 
1.3.2.g5041c-dirty
Previous: Eric W. BiedermanNext: Junio C Hamano
Message 7 of 10 in “Detect non email patches in git-mailinfo”
  1. 0/6 Detect non email patches in git-mailinfoEric W. Biederman, May 23, 2006
  2. 1/6 Make read_one_header_line return a flag not a length.Eric W. Biederman, May 23, 2006
  3. 2/6 Move B and Q decoding into check header.Eric W. Biederman, May 23, 2006
  4. 3/6 Refactor commit messge handling.Eric W. Biederman, May 23, 2006
  5. 4/6 In handle_body only read a line if we don't already have one.Eric W. Biederman, May 23, 2006
  6. 5/6 More accurately detect header lines in read_one_header_lineEric W. Biederman, May 23, 2006
  7. 6/6 Allow in body headers beyond the in body header prefix.Eric W. Biederman, May 23, 2006
  8. Junio C HamanoMay 26, 2006
  9. Junio C HamanoMay 23, 2006
  10. Eric W. BiedermanMay 26, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.