git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] MSVC: added missing include so `makeINLINE=__inline` is no longer required

From
Marat Radchenko <marat@slonopotamus.org>
Date
Mar 27, 2014, 17:43 UTC
Message-ID
<loom.20140327T183247-442@post.gmane.org>
In-Reply-To
<xmqqzjkbegdt.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster <at> pobox.com> writes:
> My gut feeling is that adding a mechanism to add -DINLINE=__inline
> only on MSVC to the top-level Makefile, without touching this file,
> may be a much more palatable.

Okay, I'll think more about this one. Maybe *moving* inline=__inline from compat-headers into Makefile (actually, config.mak.uname) will work better.

Hope it doesn't prevent first patch from being integrated -- joining them in a single thread was unintentional misuse of `git send-email` flags.

Previous: Junio C HamanoNext: Marat Radchenko
Message 4 of 5 in “MSVC: allow enabling CURL”
  1. MSVC: allow enabling CURLMarat Radchenko, Mar 27, 2014
  2. MSVC: added missing include so `make INLINE=__inline` is no longer requiredMarat Radchenko, Mar 27, 2014
  3. Junio C HamanoMar 27, 2014
  4. Marat RadchenkoMar 27, 2014
  5. MSVC: define INLINE=__inline so simple `make MSVC=1` actually worksMarat Radchenko, Mar 28, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.