git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] MSVC: define INLINE=__inline so simple `make MSVC=1` actually works

From
Marat Radchenko <marat@slonopotamus.org>
Date
Mar 28, 2014, 07:33 UTC
Message-ID
<1395992031-27200-1-git-send-email-marat@slonopotamus.org>
In-Reply-To
<xmqqzjkbegdt.fsf@gitster.dls.corp.google.com>
Without this, xdiff/xutils.c fails to compile.
Signed-off-by: Marat Radchenko <marat@slonopotamus.org>
---
I thought about removing #define inline __inline from compat/msvc.h but:
 * compat/msvc.h is included based on #if defined(_MSC_VER)
   and can be enabled even if MSVC != 1
 * compat/msvc.h also has #define __inline__ __inline and I don't see
   a nice way to handle both of them in config.mak.uname
 config.mak.uname | 1 +
 1 file changed, 1 insertion(+)
diff --git a/config.mak.uname b/config.mak.uname
index 6c7b904..38c60af 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -355,6 +355,7 @@ ifeq ($(uname_S),Windows)
 	NO_POSIX_GOODIES = UnfortunatelyYes
 	NATIVE_CRLF = YesPlease
 	DEFAULT_HELP_FORMAT = html
+	INLINE = __inline
 
 	CC = compat/vcbuild/scripts/clink.pl
 	AR = compat/vcbuild/scripts/lib.pl
-- 
1.9.1
Previous: Marat Radchenko
Message 5 of 5 in “MSVC: allow enabling CURL”
  1. MSVC: allow enabling CURLMarat Radchenko, Mar 27, 2014
  2. MSVC: added missing include so `make INLINE=__inline` is no longer requiredMarat Radchenko, Mar 27, 2014
  3. Junio C HamanoMar 27, 2014
  4. Marat RadchenkoMar 27, 2014
  5. MSVC: define INLINE=__inline so simple `make MSVC=1` actually worksMarat Radchenko, Mar 28, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.