git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: 1.8.3 - gitignore not being parsed correctly on OS X; regex support is broken?

From
Øystein Walle <oystwa@gmail.com>
Date
May 29, 2013, 18:49 UTC
Message-ID
<loom.20130529T204310-306@post.gmane.org>
In-Reply-To
<51A62A96.6040009@gmail.com>
Karsten Blees <karsten.blees <at> gmail.com> writes:
>  <at> Øystein: in the meantime, could you check if this fixes the problem 
for you?
Show 7 quoted lines
> 
> --- 8< ---
> diff --git a/dir.c b/dir.c
> index a5926fb..13858fe 100644
> --- a/dir.c
> +++ b/dir.c
>  <at>  <at>  -821,6 +821,9  <at>  <at>  static void prep_exclude(struct 
dir_struct *dir, const char *base, int baselen)
Show 9 quoted lines
>  				dir->basebuf, stk->baselen - 1,
>  				dir->basebuf + current, &dt);
>  			dir->basebuf[stk->baselen - 1] = '/';
> +			if (dir->exclude &&
> +			    dir->exclude->flags & EXC_FLAG_NEGATIVE)
> +				dir->exclude = NULL;
>  			if (dir->exclude) {
>  				dir->basebuf[stk->baselen] = 0;
>  				dir->exclude_stack = stk;
Hi, Karsten

I applied your fix on v1.8.3 on both systems I mentioned earlier and from my tests the issue I reported is fixed.

Thank you very much! :)

Regards Øsse

Previous: Karsten BleesNext: Karsten Blees
Message 8 of 16 in “1.8.3 - gitignore not being parsed correctly on OS X; regex support is broken?”
  1. Misty De MeoMay 28, 2013
  2. Øystein WalleMay 28, 2013
  3. Junio C HamanoMay 28, 2013
  4. Duy NguyenMay 29, 2013
  5. Duy NguyenMay 29, 2013
  6. David AguilarMay 29, 2013
  7. Karsten BleesMay 29, 2013
  8. Øystein WalleMay 29, 2013
  9. dir.c: fix ignore processing within not-ignored directoriesKarsten Blees, May 29, 2013
  10. Duy NguyenJun 1, 2013
  11. Junio C HamanoJun 2, 2013
  12. Karsten BleesJun 4, 2013
  13. t/README: test_must_fail is for testing GitJunio C Hamano, Jun 4, 2013
  14. Philip OakleyJun 4, 2013
  15. Junio C HamanoJun 4, 2013
  16. Philip OakleyJun 4, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.