git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: 1.8.3 - gitignore not being parsed correctly on OS X; regex support is broken?

From
Duy Nguyen <pclouds@gmail.com>
Date
May 29, 2013, 04:19 UTC
Message-ID
<CACsJy8DD=LxAKh_fUELJ5Mj0xS_gZE88N_rJFkKGer=YAOqsMg@mail.gmail.com>
In-Reply-To
<CACsJy8BqCUKhc8vhjhNz0OedBngk7zcSOk70ekRm3EiruHfNxA@mail.gmail.com>
On Wed, May 29, 2013 at 10:41 AM, Duy Nguyen <pclouds@gmail.com> wrote:
Show 9 quoted lines
> The changes in this area since 1.8.2.3 seem to be Karsten's (I'm not
> blaming, just wanted to narrow down the problem). The patterns of
> interest seem to be
>
> !/bin
> /bin/*
> !/bin/brew
>
> Without "!/bin" v1.8.3 seems to behave the same as v1.8.2.3.

Karsten, the block "/* Abort if the directory is excluded */" in prep_exclude() seems to cause this. I think it goes through the exclude patterns, hits "!/bin", believes the patterns do not make sense in this context and throws all away. I think Øystein's case falls into the same path. Commenting out the block seems to gain the old behavior back (and probably breaks other stuff). Contrary to what Junio said, I'm clueless about this. I wanted to read your series through and eventually gave up. I think I now have the motivation to look at it again this weekend. -- Duy

Previous: Duy NguyenNext: David Aguilar
Message 5 of 16 in “1.8.3 - gitignore not being parsed correctly on OS X; regex support is broken?”
  1. Misty De MeoMay 28, 2013
  2. Øystein WalleMay 28, 2013
  3. Junio C HamanoMay 28, 2013
  4. Duy NguyenMay 29, 2013
  5. Duy NguyenMay 29, 2013
  6. David AguilarMay 29, 2013
  7. Karsten BleesMay 29, 2013
  8. Øystein WalleMay 29, 2013
  9. dir.c: fix ignore processing within not-ignored directoriesKarsten Blees, May 29, 2013
  10. Duy NguyenJun 1, 2013
  11. Junio C HamanoJun 2, 2013
  12. Karsten BleesJun 4, 2013
  13. t/README: test_must_fail is for testing GitJunio C Hamano, Jun 4, 2013
  14. Philip OakleyJun 4, 2013
  15. Junio C HamanoJun 4, 2013
  16. Philip OakleyJun 4, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.