Re: [ANNOUNCE] Git 1.7.8.rc0

From: Stefan Naewe <stefan.naewe@gmail.com>
Date: Nov 1, 2011, 20:06 UTC
Message-ID: <loom.20111101T205618-231@post.gmane.org>
In-Reply-To: <7vmxcfn23i.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster <at> pobox.com> writes:

Show 27 quoted lines

> 
> [administrivia: dropped the kernel mailing list from and added Peff to Cc]
> 
> Stefan Näwe <stefan.naewe <at> atlas-elektronik.com> writes:
> 
> >>>  * HTTP transport did not use pushurl correctly, and also did not tell
> >>>    what host it is trying to authenticate with when asking for
> >>>    credentials.
> >>>    (merge deba493 jk/http-auth later to maint).
> >> 
> >> This seems to break pushing with https for me.
> >> It never uses values from my '~/.netrc'.
> >> I'll come up with a detailed scenario later.
> >
> > Update:
> >
> > git push prompts for the password but just pressing return succeeds.
> >
> > Weird...
> 
> There are only handful of commits that even remotely touch http related
> codepath between v1.7.7 and v1.7.8-rc0:
> 
> [...]
> 
> Could you try reverting deba493 and retest, and then if the behaviour is
> the same "need ENTER", further revert 070b4dd and retest?

Did some tests again at my home machine with v1.7.8-rc0.

Push with https works, if the URL looks e.g. like this:

  https://github.com/user/repo.git

rather than this

  https://user@github.com/user/repo.git

and having a ~/.netrc like this

  machine github.com login user password YouDontWantToKnow

If the URL contains 'user@' I get the 'need ENTER' behaviour.

I'll recheck everything at work, where I live behind a very restrictive firewall (Don't know if that makes any difference).

Regards,
  Stefan