Re: [ANNOUNCE] Git 1.7.8.rc0

From: Jeff King <peff@peff.net>
Date: Nov 2, 2011, 18:03 UTC
Message-ID: <20111102180327.GA30668@sigill.intra.peff.net>
In-Reply-To: <loom.20111101T211624-511@post.gmane.org>

On Tue, Nov 01, 2011 at 08:18:47PM +0000, Stefan Naewe wrote:

Show 20 quoted lines

> Stefan Naewe <stefan.naewe <at> gmail.com> writes:
> 
> > Push with https works, if the URL looks e.g. like this:
> > 
> >   https://github.com/user/repo.git
> > 
> > rather than this
> > 
> >   https://user <at> github.com/user/repo.git
> > 
> > and having a ~/.netrc like this
> > 
> >   machine github.com login user password YouDontWantToKnow
> > 
> > If the URL contains 'user@' I get the 'need ENTER' behaviour.
> > 
> 
> Another update:
> 
> If I revert deba493 the 'need ENTER' is gone and everything works as above.

I think this is a false positive. The problem that deba493 fixes is that "git push" was not properly looking at the push URL, but rather pulling the initial auth information from the fetch URL. So I suspect your finding the bug there or not may have to do with it actually respecting your config properly.

I think the bug is much older than this, and we are just exposing it by finally using the correct URL.

Without using a configured remote, try this (with .netrc configured):

  git push https://github.com/user/repo.git :refs/heads/nothing

which should work, and then this:

  git push https://user@github.com/user/repo.git :refs/heads/nothing

which will do the "must hit enter to accept password" thing.

That fails even with v1.7.7. I didn't bisect, but it has been there quite a while (v1.6.6 has it, but v1.6.5 has a weird error, so I didn't bisect further).

-Peff