Re: t7810.94 (git-grep -E -F -G) never passed
- From
Michał Kiedrowicz <michal.kiedrowicz@gmail.com>
- Date
- May 25, 2011, 21:22 UTC
- Message-ID
- <loom.20110525T231844-341@post.gmane.org>
- In-Reply-To
- <1AEF57D5-49E0-4F37-BE8D-DEBD25965D83@gernhardtsoftware.com>
Brian Gernhardt <brian <at> gernhardtsoftware.com> writes:
> > Some would be right. I tend to find that the BSD (and BSD-like) libraries on
OS X are more strict and have less
> features than the GNU equivalents. (The fact that OS X's libreadline is
actually the only mostly
> compatible libedit drives me batty sometimes.) > > This does leave us with the question of what to do with the test. Perhaps a
pattern like "a*+b" to match
> "aa+b"? Plain + should always match just + in a BRE, even if \+ is special,
and the * makes sure that it is a
Show 5 quoted lines
> regex instead of plain string matching. > > ~~ Brian > >
You're right about \+ in BRE. I guess I missed that because glibc's implementation isn't strict BRE. I'll post a patch that fixes this problem. Thanks for catching this up!