Re: t7810.94 (git-grep -E -F -G) never passed

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: May 25, 2011, 10:21 UTC
Message-ID: <4DDCD845.1030800@drmicha.warpmail.net>
In-Reply-To: <BE19630B-8E48-4CA8-B956-A4DC767BFFDD@gernhardtsoftware.com>

Brian Gernhardt venit, vidit, dixit 25.05.2011 05:27:

Show 13 quoted lines

> I'm not sure why it's supposed to pass, actually.  -G makes the pattern be a basic regex and basic regexen don't recognize the + repetition operator.
> 
> expecting success: 
> 	echo ab:aab >expected &&
> 	git grep -E -F -G a\\+b >actual &&
> 	test_cmp expected actual
> 
> --- expected	2011-05-25 03:19:05.000000000 +0000
> +++ actual	2011-05-25 03:19:05.000000000 +0000
> @@ -1 +1 @@
> -ab:aab
> +ab:a+b
> not ok - 94 grep -E -F -G pattern

"Never" is a strong statement when this test always passed for everyone else running tests, assuming they would have reported otherwise. What's your system?

reg-ex.info says:

"The other BRE metacharacters require a backslash to give them their special meaning."

"Some implementations support \? and \+... but \? and \+ are not part of the POSIX standard."

So I guess we're going with "some".

Michael