Re: [PATCH 3/3] improved validation of entry type in mktree
- From
- Josh Micich <josh.micich@gmail.com>
- Date
- May 15, 2009, 16:57 UTC
- Message-ID
- <loom.20090515T163644-832@post.gmane.org>
- In-Reply-To
- <guj1pi$tbk$1@ger.gmane.org>
Jakub Narebski <jnareb <at> gmail.com> writes:
> > Josh Micich wrote: > > > Furthermore even with '--missing', a tree entry like this should be
rejected:
> > 160000 commit e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 foo > > But with submodules you might not _have_ e69de29b in object database > to check its type!
The code already accounted for that case. If the tree entry is a GIT_LINK ("160000 commit ..."), it is not mandatory for the referenced object to exist locally. But if the object _does_ exist, the type should match. I guess I should have prefixed that example with "assuming object e69de29b (empty tree) is present in the local database".