git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] added --batch option to mktree

From
Sverre Rabbelier <srabbelier@gmail.com>
Date
May 14, 2009, 10:25 UTC
Message-ID
<fabb9a1e0905140325g2f376cf1lcaf206278a942c47@mail.gmail.com>
In-Reply-To
<a644352c0905140224g41f645c1l734bee791656ea1d@mail.gmail.com>
Heya,
On Thu, May 14, 2009 at 11:24, Josh Micich <josh.micich@gmail.com> wrote:
> If you find this logic persuasive, I can fix all the other issues and
> re-submit this patch.

I suspect Junio's point was more in the gist of "you should explain this in your commit message". So if you do resend your patch, include the above explanation (or at least the mention of the 30% speedup) in your commit message.

-- 
Cheers,

Sverre Rabbelier
Previous: Josh MicichNext: Josh Micich
Message 8 of 16 in “Proposed patch for mktree [0/3]”
  1. Josh MicichMay 14, 2009
  2. 1/3 '--missing' option for mktree: re-added strbuf_release(&p_uq), Updated man pageJosh Micich, May 14, 2009
  3. Junio C HamanoMay 14, 2009
  4. Josh MicichMay 14, 2009
  5. 2/3 added --batch option to mktreeJosh Micich, May 14, 2009
  6. Junio C HamanoMay 14, 2009
  7. Josh MicichMay 14, 2009
  8. Sverre RabbelierMay 14, 2009
  9. Josh MicichMay 14, 2009
  10. 3/3 improved validation of entry type in mktreeJosh Micich, May 14, 2009
  11. Junio C HamanoMay 14, 2009
  12. Josh MicichMay 14, 2009
  13. Josh MicichMay 14, 2009
  14. Jakub NarebskiMay 15, 2009
  15. Josh MicichMay 15, 2009
  16. Junio C HamanoMay 15, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.