Re: [PATCH] Do not send "want" lines for complete objects

From: Junio C Hamano <junkio@twinsun.com>
Date: Oct 21, 2005, 00:43 UTC
Message-ID: <loom.20051021T024100-352@post.gmane.org>
In-Reply-To: <Pine.LNX.4.63.0510210114370.10503@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin <at> gmx.de> writes:

Show 7 quoted lines

> ... I did not use it originally, because lines 
> 24-25 of commit.h say
> 
> 	/** Internal only **/
> 	struct object *lookup_object(const unsigned char *sha1);
> 
> Is this obsolete?

For this particular application, it should be OK, because:

 - it checks if we already have that object, and returns a pointer to it;
 - if we haven't seen that object, we get a NULL back;

and

 - what we care about is to see if we have checked and verified if it is
   reachable from our refs.  We do not want the check to actively go read
   and parse that object.

-jc