Re: [PATCH] Do not send "want" lines for complete objects

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 20, 2005, 23:16 UTC
Message-ID: <Pine.LNX.4.63.0510210114370.10503@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <Pine.LNX.4.64.0510201630000.25300@iabervon.org>

Hi,

On Thu, 20 Oct 2005, Daniel Barkalow wrote:

Show 14 quoted lines

> On Thu, 20 Oct 2005, Johannes Schindelin wrote:
> 
> > Hi,
> > 
> > > > +		    ((o = parse_object(remote)) != NULL) &&
> > > > +		    (o->flags & COMPLETE) &&
> > 
> > I just realized that parse_object() always reads the file, then does a 
> > lookup (which makes the above code work), and then parses the file. It 
> > always does all of these steps, even if the object was already parsed. Any 
> > reason for this?
> 
> I'm lazy and haven't sent in a patch to clean that up. There's no reason 
> it couldn't check whether the value it gets is already parsed.

Actually, you don't have to... Junio already replaced parse_object() by lookup_object() in this case. I did not use it originally, because lines 24-25 of commit.h say

	/** Internal only **/
	struct object *lookup_object(const unsigned char *sha1);

Is this obsolete?

Ciao, Dscho