Re: [RFC PATCH] cogito --- don't overwrite metadata files in place (breaks CoW use)
- From
Junio C Hamano <junkio@twinsun.com>
- Date
- Jul 12, 2005, 21:37 UTC
- Message-ID
- <loom.20050712T233332-364@post.gmane.org>
- In-Reply-To
- <20050712190552.GA7178@taniwha.stupidest.org>
Chris Wedgwood <cw <at> f00f.org> writes:
Show 5 quoted lines
> if [ "$newhead" ]; then > echo "Committed as $newhead." > - echo $newhead >$_git/HEAD > + echo_to_file $newhead $_git/HEAD > [ "$merging" ] && rm $_git/merging $_git/merging-sym $_git/merge-base
Good intentions, but wouldn't the above clobber symlinked HEAD?
Not a fundamental flaw, though. You need to see if it is a symlink, readlink it (repeatedly until you get a regular file or dangling symlink target that does not exist --- immediately after git-init-db has such a HEAD) and run your echo_to_file on the link target.