Re: [RFC PATCH] cogito --- don't overwrite metadata files in place (breaks CoW use)

From: Chris Wedgwood <cw@f00f.org>
Date: Jul 13, 2005, 21:54 UTC
Message-ID: <20050713215435.GB12882@taniwha.stupidest.org>
In-Reply-To: <Pine.LNX.4.58.0507131410430.17536@g5.osdl.org>

On Wed, Jul 13, 2005 at 02:23:18PM -0700, Linus Torvalds wrote:

> If you really want to do something like this, then you should do it like
> this:
>
> 	update_head() {

except there are a number of places I need to frob things in Cogito and they are not all for the head. If the head is special and the only candidate sure, that works for me.

>  - following multiple links is _wrong_, since the next-level link could
>    actually be a symlink to another tree entirely (if somebody is crazy
>    enough to use "cp -Rl" to copy trees, then why not "cp -Rs"?)

I already stated that wasn't supposed to work. If you have symlinks outside of your tree with cogito I think there is a *lot* more code that probably needs to be checked.

Remember I used cogito here, not git directly. That probably means things are invoked very differently for me?

>  - you got relative links wrong.

Possibly, I was more for RFC/concept reasons I posted the patch. I'm clueless when it comes to writing decent or reliable bash sh/bash scripts.