Re: [PATCH] fast-import: Remove redundant assignment of 'oe' to itself.

From: Joachim Schmitz <jojo@schmitz-digital.de>
Date: May 28, 2013, 08:22 UTC
Message-ID: <ko1pfi$7f6$1@ger.gmane.org>
In-Reply-To: <51A26BB7.3060702@gmail.com>

Stefano Lattarini wrote:

Show 26 quoted lines

> On 05/26/2013 10:05 PM, Stefan Beller wrote:
>> Reported by cppcheck.
>>
>> Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
>> ---
>>  fast-import.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fast-import.c b/fast-import.c
>> index 5f539d7..0142e3a 100644
>> --- a/fast-import.c
>> +++ b/fast-import.c
>> @@ -2914,7 +2914,7 @@ static void cat_blob(struct object_entry *oe,
>>  unsigned char sha1[20]) static void parse_cat_blob(void)
>>  {
>>  const char *p;
>> - struct object_entry *oe = oe;
>>
> This was done on purpose, to avoid spurious warnings with (at least)
> some versions of GCC.
>
>> + struct object_entry *oe;
>>  unsigned char sha1[20];
>>
>>  /* cat-blob SP <object> LF */
>

This strange construct has been removed in other places meanwhile. It is violating C-standards (C89, C99) and as such causes warnings with other compilers, so this is fighting fire with fire. As it is a pointer it may be more sensible to initialize with NULL, should appease all compilers and still be correct.

Bye, Jojo