Re: [PATCH] fast-import: Remove redundant assignment of 'oe' to itself.

From: Stefano Lattarini <stefano.lattarini@gmail.com>
Date: May 26, 2013, 20:08 UTC
Message-ID: <51A26BB7.3060702@gmail.com>
In-Reply-To: <1369598719-10798-1-git-send-email-stefanbeller@googlemail.com>

On 05/26/2013 10:05 PM, Stefan Beller wrote:

Show 17 quoted lines

> Reported by cppcheck.
> 
> Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
> ---
>  fast-import.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fast-import.c b/fast-import.c
> index 5f539d7..0142e3a 100644
> --- a/fast-import.c
> +++ b/fast-import.c
> @@ -2914,7 +2914,7 @@ static void cat_blob(struct object_entry *oe, unsigned char sha1[20])
>  static void parse_cat_blob(void)
>  {
>  	const char *p;
> -	struct object_entry *oe = oe;
>

This was done on purpose, to avoid spurious warnings with (at least) some versions of GCC.

> +	struct object_entry *oe;
>  	unsigned char sha1[20];
>  
>  	/* cat-blob SP <object> LF */

Regards,
  Stefano