git/list[1] front-page[2] threads[3] people[4] search[5] about
 

ab/submodule-no-abspath (was Re: What's cooking in git.git (Nov 2022, #04; Fri, 18))

From
Glen Choo <chooglen@google.com>
Date
Nov 21, 2022, 22:22 UTC
Message-ID
<kl6ltu2sdk1r.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To
<Y3g95OYdwzq2OP3z@nand.local>
Taylor Blau <me@ttaylorr.com> writes:
Show 10 quoted lines
> * ab/submodule-no-abspath (2022-11-09) 1 commit
>   (merged to 'next' on 2022-11-18 at 34d0accc7b)
>  + submodule--helper absorbgitdirs: no abspaths in "Migrating git..."
>  (this branch is used by ab/remove--super-prefix.)
>
>  Remove an absolute path in the "Migrating git directory" message.
>
>  Will merge to 'master'.
>  source: <patch-1.1-34b54fdd9bb-20221109T020347Z-avarab@gmail.com>
>
(Sorry, I should have spoken up before this got merged to 'next'.)
I have some reservations about this that I mentioned in [1], namely:
- Does this work correctly when using a worktree?
- If "absorbgitdirs" becomes consistent with other "git submodule"
  subcommands and prints relative paths to submodules, then this
  produces the wrong result.

We probably won't see any complaints about this for a while, since submodules + worktrees are an uncommon combination, but I expect that we'll have to revert this at some point.

[1] https://lore.kernel.org/git/kl6lmt8qv9gc.fsf@chooglen-macbookpro.roam.corp.google.com
Previous: Junio C HamanoNext: Ævar Arnfjörð Bjarmason
Message 20 of 22 in “What's cooking in git.git (Nov 2022, #04; Fri, 18)”
  1. Taylor BlauNov 19, 2022
  2. SZEDER GáborNov 20, 2022
  3. Looking for a review (pretty-formats, hard truncation), was What's cooking in git.git (Nov 2022, #04; Fri, 18))Philip Oakley, Nov 20, 2022
  4. Junio C HamanoNov 21, 2022
  5. Philip OakleyNov 21, 2022
  6. Phillip WoodNov 20, 2022
  7. Johannes SchindelinNov 20, 2022
  8. Junio C HamanoNov 21, 2022
  9. Taylor BlauNov 21, 2022
  10. Phillip WoodNov 22, 2022
  11. Junio C HamanoNov 20, 2022
  12. Taylor BlauNov 20, 2022
  13. Junio C HamanoNov 20, 2022
  14. Taylor BlauNov 20, 2022
  15. Junio C HamanoNov 21, 2022
  16. Taylor BlauNov 22, 2022
  17. Junio C HamanoNov 21, 2022
  18. Taylor BlauNov 21, 2022
  19. Junio C HamanoNov 23, 2022
  20. ab/submodule-no-abspath (was Re: What's cooking in git.git (Nov 2022, #04; Fri, 18))Glen Choo, Nov 21, 2022
  21. submodule absorbgitdirs: use relative <from> and <to> pathsÆvar Arnfjörð Bjarmason, Nov 22, 2022
  22. Glen ChooNov 23, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.