git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Looking for a review (pretty-formats, hard truncation), was What's cooking in git.git (Nov 2022, #04; Fri, 18))

From
Philip Oakley <philipoakley@iee.email>
Date
Nov 20, 2022, 17:42 UTC
Message-ID
<8791cb85-cf4a-4302-5c1a-54a7e7766cfb@iee.email>
In-Reply-To
<Y3g95OYdwzq2OP3z@nand.local>
Ping, Hopefully an easy single patch review for someone on-list.

Patch [v4] itself: https://lore.kernel.org/git/20221112143616.1429-1-philipoakley@iee.email/

Available at: https://github.com/ttaylorr/git/tree/po/pretty-hard-trunc
On 19/11/2022 02:22, Taylor Blau wrote:
Show 10 quoted lines
> --------------------------------------------------
> [Cooking]
>
> * po/pretty-hard-trunc (2022-11-13) 1 commit
>  - pretty-formats: add hard truncation, without ellipsis, options
>
>  Add a new pretty format which truncates without ellipsis.
>
>  Waiting for review.
>  source: <20221112143616.1429-1-philipoakley@iee.email>
Potential review points:

Is the commit message sufficient? Are the tests: Sufficient,  Complete, Correct ? Is `qz_to_tab_space` conversion applied correctly?

-- Philip

Previous: SZEDER GáborNext: Junio C Hamano
Message 3 of 22 in “What's cooking in git.git (Nov 2022, #04; Fri, 18)”
  1. Taylor BlauNov 19, 2022
  2. SZEDER GáborNov 20, 2022
  3. Looking for a review (pretty-formats, hard truncation), was What's cooking in git.git (Nov 2022, #04; Fri, 18))Philip Oakley, Nov 20, 2022
  4. Junio C HamanoNov 21, 2022
  5. Philip OakleyNov 21, 2022
  6. Phillip WoodNov 20, 2022
  7. Johannes SchindelinNov 20, 2022
  8. Junio C HamanoNov 21, 2022
  9. Taylor BlauNov 21, 2022
  10. Phillip WoodNov 22, 2022
  11. Junio C HamanoNov 20, 2022
  12. Taylor BlauNov 20, 2022
  13. Junio C HamanoNov 20, 2022
  14. Taylor BlauNov 20, 2022
  15. Junio C HamanoNov 21, 2022
  16. Taylor BlauNov 22, 2022
  17. Junio C HamanoNov 21, 2022
  18. Taylor BlauNov 21, 2022
  19. Junio C HamanoNov 23, 2022
  20. ab/submodule-no-abspath (was Re: What's cooking in git.git (Nov 2022, #04; Fri, 18))Glen Choo, Nov 21, 2022
  21. submodule absorbgitdirs: use relative <from> and <to> pathsÆvar Arnfjörð Bjarmason, Nov 22, 2022
  22. Glen ChooNov 23, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.