Re: [PATCH] object-file: use real paths when adding alternates

From: Glen Choo <chooglen@google.com>
Date: Nov 18, 2022, 00:00 UTC
Message-ID: <kl6lsfihgmib.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <Y3auRnJqHq3pMKAe@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 7 quoted lines

> On Thu, Nov 17, 2022 at 08:41:44PM +0100, Ævar Arnfjörð Bjarmason wrote:
>
>> This probably isn't worth it, but I wondered if this wouldn't be easier
>> if we pulled that memory management into the caller [...]
> [......] But crossing a function boundary to me introduces way too many
> questions in somebody reading the code (like "is pathbuf supposed to
> have something in it?") to make it worth doing here.

Thanks, both :)

I think the loss of readability is enough for me to hold off on this suggestion, but I don't mind reviewing cleanup patches on top of this.