Re: [PATCH] object-file: use real paths when adding alternates

From: Taylor Blau <me@ttaylorr.com>
Date: Nov 17, 2022, 21:54 UTC
Message-ID: <Y3atneCCAA4fMFKL@nand.local>
In-Reply-To: <pull.1382.git.git.1668706274099.gitgitgadget@gmail.com>

On Thu, Nov 17, 2022 at 05:31:13PM +0000, Glen Choo via GitGitGadget wrote:

Show 9 quoted lines

> From: Glen Choo <chooglen@google.com>
>
> When adding an alternate ODB, we check if the alternate has the same
> path as the object dir, and if so, we do nothing. However, that
> comparison does not resolve symlinks. This makes it possible to add the
> object dir as an alternate, which may result in bad behavior. For
> example, it can trick "git repack -a -l -d" (possibly run by "git gc")
> into thinking that all packs come from an alternate and delete all
> objects.

Nice find and fix. Looks like Peff had a couple of good suggestions which I'd like to see incorporated into another version before we pick this up.

Otherwise, looking at the patch myself, it seems obviously good. Thanks for working on it.

Thanks, Taylor