Re: [PATCH v5 1/2] branch: accept multiple upstream branches for tracking
- From
Glen Choo <chooglen@google.com>
- Date
- Dec 9, 2021, 00:08 UTC
- Message-ID
- <kl6lo85qabch.fsf@chooglen-macbookpro.roam.corp.google.com>
- In-Reply-To
- <kl6lr1amac23.fsf@chooglen-macbookpro.roam.corp.google.com>
Glen Choo <chooglen@google.com> writes:
Show 5 quoted lines
> We print ref_string, which is a strbuf. This causes t/t3200-branch.sh to > segfault on my mac + clang, but inconsistently! With -O2, it doesn't > always segfault, but the wrong memory is read: > > Branch 'my3' set up to track remote branch local from 'Branch '%s' set up to track remote branch %s from '%s'.'.
I forgot to mention this earlier but in this example, the test *passes* even though the stderr message is obviously wrong. I don't see any coverage of the help message in t3200, which is a bit worrying to me.
After this series is done, is it worth adding test coverage of the help message?