Re: [PATCH 4/5] trailer: teach find_patch_start about --no-divider

From: Glen Choo <chooglen@google.com>
Date: Aug 11, 2023, 20:51 UTC
Message-ID: <kl6l8rah8fq6.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <owlyjzu2fjz9.fsf@fine.c.googlers.com>

Linus Arver <linusa@google.com> writes:

> I don't see why we should preserve the if-statement and associated
> strlen() call if we can just get rid of it.

Here are some reasons:

- Without compiler optimizations, it is faster.
- Subjectively, I find the early return easier to understand.

I don't think I need to nitpick over such a tiny issue though, so I'm okay either way.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.