Re: [PATCH 3/4] t/t4018: test whether the word_regex patterns compile

From: Brandon Casey <casey@nrlssc.navy.mil>
Date: Sep 9, 2010, 19:39 UTC
Message-ID: <j45XQiddacaKt4L280HjYoaYzAnnDCuR2Yspxw_iRDyU3Y9YkKMxAQ@cipher.nrlssc.navy.mil>
In-Reply-To: <20100909192331.GD32508@sigill.intra.peff.net>

On 09/09/2010 02:23 PM, Jeff King wrote:

Show 27 quoted lines

> On Thu, Sep 09, 2010 at 02:02:47PM -0500, Brandon Casey wrote:
> 
>> From: Brandon Casey <drafnel@gmail.com>
>>
>> Previously (e3bf5e43), a test was added to test whether the builtin
>> xfuncname regular expressions could be compiled without error by regcomp.
>> Let's do the same for the word_regex patterns.  This should help catch any
>> cross-platform incompatibilities that exist between the pattern creator's
>> system and the various platforms that the test suite is commonly run on.
> 
> Definitely something we should be doing, but one nit:
> 
>> diff --git a/t/t4018-diff-funcname.sh b/t/t4018-diff-funcname.sh
>> index 61de8a2..620cd02 100755
>> --- a/t/t4018-diff-funcname.sh
>> +++ b/t/t4018-diff-funcname.sh
>> @@ -40,6 +40,11 @@ do
>>  		! ( git diff --no-index Beer.java Beer-correct.java 2>&1 |
>>  			grep "fatal" > /dev/null )
>>  	'
>> +	test_expect_success "builtin $p wordRegex pattern compiles" '
>> +		! ( git diff --no-index --word-diff \
>> +			Beer.java Beer-correct.java 2>&1 |
>> +			grep "fatal" > /dev/null )
>> +	'
> 
> Why the subshell? Shouldn't just testing the pipeline outcome work?

Notice the similarity between the added lines and the lines just above them? Where were you when I submitted those? :)

Thanks, -Brandon