git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] userdiff.c: add builtin fortran regex patterns

From
Jeff King <peff@peff.net>
Date
Sep 9, 2010, 19:25 UTC
Message-ID
<20100909192556.GE32508@sigill.intra.peff.net>
In-Reply-To
<rRj7JpFIk_D_n7-wGkkucKFVckLzqXnIAA17N9A643YqyUkXvOqBHrthWFrRRIbouApw4_WLoBE@cipher.nrlssc.navy.mil>
On Thu, Sep 09, 2010 at 02:02:48PM -0500, Brandon Casey wrote:
Show 5 quoted lines
> This adds fortran xfuncname and wordRegex patterns to the list of builtin
> patterns.  The intention is for the patterns to be appropriate for all
> versions of fortran including 77, 90, 95.  The patterns can be enabled by
> adding the diff=fortran attribute to the .gitattributes file for the
> desired file glob.

The rest of your series looks reasonable, modulo the comments I posted to individual patches. But I won't torture my eyes by trying to actually see how well this matches fortran code, and just assume this is a good change. :)

> This also adds a new macro named iPATTERN which is just like the PATTERNS
> macro except it sets the REG_ICASE flag so that case will be ignored.
Style nit: please keep macros all uppercase.
-Peff
Previous: Brandon CaseyNext: Brandon Casey
Message 13 of 16 in “diff.c: call regfree to free memory allocated by regcomp when necessary”
  1. 1/4 diff.c: call regfree to free memory allocated by regcomp when necessaryBrandon Casey, Sep 9, 2010
  2. 2/4 xdiff-interface.c: always trim trailing space from xfuncname matchesBrandon Casey, Sep 9, 2010
  3. Jeff KingSep 9, 2010
  4. Brandon CaseySep 9, 2010
  5. Jeff KingSep 9, 2010
  6. 3/4 t/t4018: test whether the word_regex patterns compileBrandon Casey, Sep 9, 2010
  7. Jeff KingSep 9, 2010
  8. Brandon CaseySep 9, 2010
  9. Jeff KingSep 9, 2010
  10. t/t4018: avoid two unnecessary sub-shell invocationsBrandon Casey, Sep 10, 2010
  11. Ævar Arnfjörð BjarmasonSep 10, 2010
  12. 4/4 userdiff.c: add builtin fortran regex patternsBrandon Casey, Sep 9, 2010
  13. Jeff KingSep 9, 2010
  14. Brandon CaseySep 9, 2010
  15. 4/4 userdiff.c: add builtin fortran regex patternsBrandon Casey, Sep 10, 2010
  16. Jeff KingSep 9, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.