Re: [PATCH] Define a version of lstat(2) specially for copy operation
- From
Mark Levedahl <mlevedahl@gmail.com>
- Date
- Mar 18, 2009, 03:17 UTC
- Message-ID
- <gppp48$5sc$1@ger.gmane.org>
- In-Reply-To
- <20090317213820.GC13458@blimp.localdomain>
Alex Riesen wrote:
Show 10 quoted lines
> So that Cygwin port can continue work around its supporting > library and get access to its faked file attributes. > > Signed-off-by: Alex Riesen <raa.lkml@gmail.com> > --- > Junio C Hamano, Tue, Mar 17, 2009 21:42:31 +0100: >> But isn't this something shops that do deploy Cygwin version of git want >> to see fixed, so that they can have a site-wide policy implemented in the > > Frankly, I doubt they know or care.
Please don't presume to speak for the world here. I have a not insignificant group of users, many on Cygwin, and we depend upon identical behavior between Linux and Cygwin versions of git. I maintain my own local build of git for my group, among other reasons is to disable the non-Posix lstat hack. Using the Win32 lstat does not speed up git that much (maybe 20-30% in my experience) and this trade-off of compatibility vs being not quite so dreadfully slow is certainly not worth it for me. (Obviously, others have a different view, or this feature would not exist).
So, I strongly urge keeping the differences between POSIX/Linux git and Cygwin git as minimal as possible.
Mark Levedahl