git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] disable post-checkout test on Cygwin

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Mar 17, 2009, 16:59 UTC
Message-ID
<49BFD6DD.1010800@viscovery.net>
In-Reply-To
<7vprggqeh2.fsf@gitster.siamese.dyndns.org>
Junio C Hamano schrieb:
Show 10 quoted lines
> Alex Riesen <raa.lkml@gmail.com> writes:
> 
>> It is broken because of the tricks we have to play with
>> lstat to get the bearable perfomance out of the call.
>> Sadly, it disables access to Cygwin's executable attribute,
>> which Windows filesystems do not have at all.
> 
> Hmm, perhaps when checking hooks to see if they are executable, Cygwin
> port should avoid using the "tricks"?  Compared to paths inside the
> worktree the number of hooks is a lot smaller, no?

Hmm. Nowadays, we run hooks through run_hook() in run_command.c. It uses access(..., X_OK), not lstat(). We don't play games with access(), do we?

-- Hannes
Previous: Junio C HamanoNext: Alex Riesen
Message 3 of 14 in “disable post-checkout test on Cygwin”
  1. disable post-checkout test on CygwinAlex Riesen, Mar 17, 2009
  2. Junio C HamanoMar 17, 2009
  3. Johannes SixtMar 17, 2009
  4. Alex RiesenMar 17, 2009
  5. Junio C HamanoMar 17, 2009
  6. Define a version of lstat(2) specially for copy operationAlex Riesen, Mar 17, 2009
  7. Mark LevedahlMar 18, 2009
  8. Alex RiesenMar 18, 2009
  9. Junio C HamanoMar 18, 2009
  10. Johannes SixtMar 18, 2009
  11. Junio C HamanoMar 18, 2009
  12. Johannes SixtMar 18, 2009
  13. Junio C HamanoMar 18, 2009
  14. Alex RiesenMar 17, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.