Re: [PATCH v2 0/5] Fixes for Documentation/MyFirstObjectWalk.txt
- From
Dirk Gouders <dirk@gouders.net>
- Date
- Mar 23, 2024, 23:06 UTC
- Message-ID
- <gh4jcwzgxz.fsf@gouders.net>
- In-Reply-To
- <p5fii3tmfb6l7dgc2p35euwv4cp6ag64qqhb63wfu75iphqknu@tdo5ru6modr3>
Kyle Lippincott <spectral@google.com> writes:
Show 20 quoted lines
> On Tue, Mar 19, 2024 at 12:23:10PM +0100, Dirk Gouders wrote: >> The second spin for this series. >> --- >> Changes since v1: >> * Added Emily to Cc in the hope for a review >> * Remove superfluous tags from [1/5] and [3/5] >> * Replace bashism `|&` by `2>&1 |` in [5/5] >> --- >> Dirk Gouders (5): >> MyFirstObjectWalk: use additional arg in config_fn_t >> MyFirstObjectWalk: fix misspelled "builtins/" >> MyFirstObjectWalk: fix filtered object walk >> MyFirstObjectWalk: fix description for counting omitted objects >> MyFirstObjectWalk: add stderr to pipe processing >> >> Documentation/MyFirstObjectWalk.txt | 36 ++++++++++++++++------------- >> 1 file changed, 20 insertions(+), 16 deletions(-) > > Aside from the small comments on 4 and 5, series looks good to me, thanks for > working on this.
Thanks for the review -- especially for the detailed explanation and suggestions on 4.
Dirk