Re: [PATCH] Don't force imap.host to be set when imap.tunnel is set
Show 5 quoted lines
> I think Junio's point is that it's easy to start dereferencing NULL,
> because later parts of the code assume that "host" is always set, even
> if only to use it for informational purposes. So those callsites either
> need to be fixed to handle a NULL host, or perhaps something like this
> instead (totally untested):
Agreed. Yours is a much better solution.
Andy
--
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com