From: Andy Parkins <andyparkins@gmail.com>
Date: Tue, 22 Apr 2008 15:07:12 GMT
Subject: Re: [PATCH] Don't force imap.host to be set when imap.tunnel is set
Message-ID: <fukuv0$aba$1@ger.gmane.org>
In-Reply-To: <20080422104146.GA11198@sigill.intra.peff.net>

Jeff King wrote:

> I think Junio's point is that it's easy to start dereferencing NULL,
> because later parts of the code assume that "host" is always set, even
> if only to use it for informational purposes. So those callsites either
> need to be fixed to handle a NULL host, or perhaps something like this
> instead (totally untested):

Agreed.  Yours is a much better solution.


Andy
-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com