git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH JGIT 1/2] Calculate CRC32 on Pack Index v2

From
Daniel Cheng <j16sdiz+freenet@gmail.com>
Date
Mar 26, 2009, 00:49 UTC
Message-ID
<ff6a9c820903251749q41977ee0wf776a43dc8e420fb@mail.gmail.com>
In-Reply-To
<49CA3218.9090202@gmail.com>

On Wed, Mar 25, 2009 at 9:31 PM, Marek Zawirski <marek.zawirski@gmail.com> wrote:

> Hi,
>
> Thanks for spotting this bug.
> (...)
[...]
>
> Have you tested that code? It seems that CRC32 updates is  missing in
> write() method... or did I slept too short this night?:)
Sure I have tested some code, the wrong one.

The buggy code is at PackWriter.writeIndex(), and the test case I have tested is using IndexPack.index().

.. hm...
I am thinking if we can combine two of them.
> Best,
> Marek
>
Previous: Shawn O. Pearce
Message 7 of 7 in “[JGit] Mismatch CRC in packed objects from `jgit push`”
  1. Daniel ChengMar 24, 2009
  2. [JGIT Test Case] This (incomplete) test case demo the index wrong CRC bug.Daniel Cheng (aka SDiZ), Mar 24, 2009
  3. 1/2 Calculate CRC32 on Pack Index v2Daniel Cheng (aka SDiZ), Mar 25, 2009
  4. 2/2 Test case for pack index CRCDaniel Cheng (aka SDiZ), Mar 25, 2009
  5. Marek ZawirskiMar 25, 2009
  6. Shawn O. PearceMar 25, 2009
  7. Daniel ChengMar 26, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.