From: Daniel Cheng <j16sdiz+freenet@gmail.com>
Date: Thu, 26 Mar 2009 00:49:18 GMT
Subject: Re: [PATCH JGIT 1/2] Calculate CRC32 on Pack Index v2
Message-ID: <ff6a9c820903251749q41977ee0wf776a43dc8e420fb@mail.gmail.com>
In-Reply-To: <49CA3218.9090202@gmail.com>

On Wed, Mar 25, 2009 at 9:31 PM, Marek Zawirski
<marek.zawirski@gmail.com> wrote:
> Hi,
>
> Thanks for spotting this bug.
> (...)
[...]
>
> Have you tested that code? It seems that CRC32 updates is  missing in
> write() method... or did I slept too short this night?:)

Sure I have tested some code, the wrong one.

The buggy code is at PackWriter.writeIndex(), and
the test case I have tested is using IndexPack.index().

.. hm...

I am thinking if we can combine two of them.

> Best,
> Marek
>