git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Git Test Coverage Report (Tuesday, Sept 25)

From
Derrick Stolee <stolee@gmail.com>
Date
Sep 27, 2018, 15:16 UTC
Message-ID
<ff1d5836-c8a1-69a6-0f7a-815187ec16a7@gmail.com>
In-Reply-To
<6e9e1cb6-8c26-b996-dd6b-411592458f20@gmail.com>
On 9/27/2018 11:14 AM, Ben Peart wrote:
Show 45 quoted lines
>
>
> On 9/26/2018 2:44 PM, Derrick Stolee wrote:
>> On 9/26/2018 1:59 PM, Junio C Hamano wrote:
>>> Derrick Stolee <stolee@gmail.com> writes:
>>>
>>
>> Perhaps removing the middle columns of data and just "<sha> <num>) 
>> <line>" would be easier? We could also remove tabs to save space. For 
>> example:
>>
>> builtin/remote.c
>> 5025425dfff  864) return error(_("No such remote: '%s'"), name);
>>
>> commit-reach.c
>> b67f6b26e35 559) continue;
>> b67f6b26e35 569) from->objects[i].item->flags |= assign_flag;
>> b67f6b26e35 570) continue;
>> b67f6b26e35 576) result = 0;
>> b67f6b26e35 577) goto cleanup;
>>
>> ll-merge.c
>> d64324cb60e 379) marker_size = DEFAULT_CONFLICT_MARKER_SIZE;
>>
>> remote-curl.c
>> c3b9bc94b9b  181) options.filter = xstrdup(value);
>>
>> This does still pad the data by a bit, but should be more readable. 
>> Most "uncovered" code will be indented at least one level.
>>
>> We do lose the author information, but keen readers could identify 
>> code they are interested in by filename and then look up the commit 
>> by OID later.
>>
>
> I personally find the author data very useful as it makes it trivial 
> for me to scan for and find changes I'm responsible for. Just scanning 
> the output of the mail and looking for file names I may have changed 
> lately is much more laborious - meaning I'm much less likely to 
> actually do it :-).
>
> Perhaps a reasonable compromise would be to put the author name once 
> with the block of changes (like you are doing for the file name) 
> rather than on every line that changed and wasn't executed.
>

I've been playing with an extra footer that gives the 'git log --oneline' output for all commits mentioned in the line-by-line summary. While it isn't right next to the code, it would be something to look at if you only have time to check "Are any of these lines mine?"

Previous: Ben PeartNext: Elijah Newren
Message 14 of 15 in “Git Test Coverage Report (Tuesday, Sept 25)”
  1. Derrick StoleeSep 25, 2018
  2. Ben PeartSep 25, 2018
  3. Derrick StoleeSep 26, 2018
  4. Jason PyeronSep 26, 2018
  5. Derrick StoleeSep 26, 2018
  6. Thomas GummererSep 26, 2018
  7. Derrick StoleeSep 26, 2018
  8. Ben PeartSep 27, 2018
  9. Derrick StoleeSep 27, 2018
  10. Ævar Arnfjörð BjarmasonSep 27, 2018
  11. Junio C HamanoSep 26, 2018
  12. Derrick StoleeSep 26, 2018
  13. Ben PeartSep 27, 2018
  14. Derrick StoleeSep 27, 2018
  15. Elijah NewrenSep 26, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.