Re: Git Test Coverage Report (Tuesday, Sept 25)

From: Ben Peart <peartben@gmail.com>
Date: Sep 27, 2018, 15:21 UTC
Message-ID: <225dc2e3-1aa0-ac19-26e6-59b54dfe871c@gmail.com>
In-Reply-To: <a7228cb5-5085-e1c7-0731-d37b19cdc3bf@gmail.com>

On 9/26/2018 2:54 PM, Derrick Stolee wrote:

Show 38 quoted lines

> On 9/26/2018 2:43 PM, Thomas Gummerer wrote:
>> On 09/26, Derrick Stolee wrote:
>>> This is a bit tricky to do, but I will investigate. For some things, the
>>> values can conflict with each other (GIT_TEST_SPLIT_INDEX doesn't play
>>> nicely with other index options, I think).
>> Just commenting on this point.  I think all the index options should
>> be playing nicely with eachother.  I occasionally run the test suite
>> with some of them turned on, and if something failed that was always
>> an actual bug.  The different modes can be used in different
>> combinations in the wild as well, so we should get them to interact
>> nicely in the test suite.
> 
> Thanks! I'm still working out details on this, since the test suite is 
> broken with GIT_TEST_COMMIT_GRAPH due to a verbosity issue [1], which I 
> forgot until I ran the tests with the variable on.
> 
> I'll re-run with these variables:
> 
> GIT_TEST_SPLIT_INDEX=1
> 
> GIT_TEST_FULL_IN_PACK_ARRAY=1
> 
> GIT_TEST_OE_SIZE=128
> 
> GIT_TEST_OE_DELTA_SIZE=128
> 
> GIT_TEST_VALIDATE_INDEX_CACHE_ENTRIES=1
> 
> GIT_TEST_FSMONITOR=$PWD/t/t7519/fsmonitor-all
> 
> GIT_TEST_INDEX_VERSION=4
> 
> GIT_TEST_PRELOAD_INDEX=1
> 
> GIT_TEST_DISABLE_EOIE=1
> 
> GIT_TEST_INDEX_THREADS=1
>

Because the test repos are so small (ie smaller than 10K files), the test suite already executes as if GIT_TEST_INDEX_THREADS=1 is set (ie single threaded). I added the test variable so that the multi-threading code could be forced to execute in spite of the default minimum number of files logic.

I'd recommend you set GIT_TEST_INDEX_THREADS=3 instead. (3 because 1 thread is used for loading the index extensions and we need 2 or more threads available to exercise multi-threaded loading of the index entries).

Show 8 quoted lines

> Thanks,
> 
> -Stolee
> 
> [1] 
> https://public-inbox.org/git/60aae3d6-35b2-94fb-afd7-6978e935a4f7@gmail.com/ 
> 
>