git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 3/3] send-email: separate the confirmation prompts from the messages

From
DSDragan Simic <dsimic@manjaro.org>
Date
Apr 10, 2024, 03:53 UTC
Message-ID
<feabd3a4b4fc6f03d31b59340bc238cc@manjaro.org>
In-Reply-To
<bc3998b1c9bbdbc75287735b42013f52@manjaro.org>
On 2024-04-09 05:25, Dragan Simic wrote:
Show 10 quoted lines
> On 2024-04-08 23:21, Junio C Hamano wrote:
>> When $confirm is set to 'never', you have both $needs_separtor and
>> $prompt_separator set.  Would it mean you'd have two extra blank
>> lines for that message?
> 
> Actually, there are no unneeded blank lines in that case, which
> I've also tested before sending the patches.  One of the blank
> lines (the one for $needs_separator) goes after the patch messages,
> and the other one (the one for $prompt_separator) goes after the
> prompt, which is displayed before the patch messages.

Actually, there's a much, _much_ simpler solution for everything, which also works as expected when running "git send-email --quiet" with sendmail.confirm set to "auto" or "never".

I need to test it a bit more, and I'll send the updated patches.
Previous: Dragan SimicNext: Dragan Simic
Message 9 of 10 in “send-email: make produced outputs more readable”
  1. 0/3 send-email: make produced outputs more readableDragan Simic, Apr 7, 2024
  2. 1/3 send-email: move newline character out of a translatable stringDragan Simic, Apr 7, 2024
  3. 2/3 send-email: make it easy to discern the messages for each patchDragan Simic, Apr 7, 2024
  4. Junio C HamanoApr 8, 2024
  5. Dragan SimicApr 9, 2024
  6. 3/3 send-email: separate the confirmation prompts from the messagesDragan Simic, Apr 7, 2024
  7. Junio C HamanoApr 8, 2024
  8. Dragan SimicApr 9, 2024
  9. Dragan SimicApr 10, 2024
  10. Dragan SimicApr 10, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.