From: Dragan Simic <dsimic@manjaro.org>
Date: Wed, 10 Apr 2024 03:53:35 GMT
Subject: Re: [PATCH v5 3/3] send-email: separate the confirmation prompts from the messages
Message-ID: <feabd3a4b4fc6f03d31b59340bc238cc@manjaro.org>
In-Reply-To: <bc3998b1c9bbdbc75287735b42013f52@manjaro.org>

On 2024-04-09 05:25, Dragan Simic wrote:
> On 2024-04-08 23:21, Junio C Hamano wrote:
>> When $confirm is set to 'never', you have both $needs_separtor and
>> $prompt_separator set.  Would it mean you'd have two extra blank
>> lines for that message?
> 
> Actually, there are no unneeded blank lines in that case, which
> I've also tested before sending the patches.  One of the blank
> lines (the one for $needs_separator) goes after the patch messages,
> and the other one (the one for $prompt_separator) goes after the
> prompt, which is displayed before the patch messages.

Actually, there's a much, _much_ simpler solution for everything,
which also works as expected when running "git send-email --quiet"
with sendmail.confirm set to "auto" or "never".

I need to test it a bit more, and I'll send the updated patches.