git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] csum-file: add hashwrite_be64()

From
Derrick Stolee <stolee@gmail.com>
Date
Nov 12, 2020, 13:52 UTC
Message-ID
<fcebe67f-f1d7-0069-01de-12844508cae1@gmail.com>
In-Reply-To
<16932ced-8bcd-89bd-b927-cae1bce0365a@web.de>
On 11/12/2020 7:20 AM, René Scharfe wrote:
Show 7 quoted lines
> Add a helper function for hashing and writing 64-bit integers in network
> byte order.  It returns the number of written bytes.  This simplifies
> callers that keep track of the file offset, even though this number is a
> constant.
> 
> Suggested-by: Derrick Stolee <dstolee@microsoft.com>
> Original-patch-by: Taylor Blau <me@ttaylorr.com>

These patches are absolutely correct, and I'm glad to see them show up in a very clear presentation. I had to go look to see why these were not already present, with [1] being the last instance of these showing up on-list. They did not get into the new version after a significant refactor [2].

Thanks, -Stolee

[1] https://lore.kernel.org/git/20200904202226.GA21837@nand.local/ [2] https://lore.kernel.org/git/cover.1599664389.git.me@ttaylorr.com/

Previous: René ScharfeNext: Taylor Blau
Message 4 of 6 in “csum-file: add hashwrite_be64()”
  1. 1/3 csum-file: add hashwrite_be64()René Scharfe, Nov 12, 2020
  2. 2/3 midx: use hashwrite_be64()René Scharfe, Nov 12, 2020
  3. 3/3 pack-write: use hashwrite_be64()René Scharfe, Nov 12, 2020
  4. Derrick StoleeNov 12, 2020
  5. Taylor BlauNov 12, 2020
  6. Taylor BlauNov 12, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.