git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix memory corruption when .gitignore does not end by \n

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Jan 21, 2010, 01:38 UTC
Message-ID
<fcaeb9bf1001201738x5cd374c2o280ec42d6d65c0f7@mail.gmail.com>
In-Reply-To
<7v3a20367d.fsf@alter.siamese.dyndns.org>
On 1/21/10, Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>  >  This patch causes a crash for me. Not sure if it does for anybody else.
>
>
> I am puzzled.  What do you mean by this?  If this patch makes the code
>  crash, then it is not a fix.  Is this meant as "Jonathan, can you try this
>  patch and tell me what happens, so that I can diagnose the issue better?"
>  patch?

I mean the t3001 patch in comment part, which removes \n at the end of .gitignore and crashes the unmodified git.

IOW I found a problem and this patch (not the t3001 one) should fix it. Not sure if this causes Jonathan problem though.

>  Is it better/safer to revert the entire nd/sparse topic from the master in
>  the meantime before we know what is going on?

I would wait for Jonathan response. If this is not the cause, probably safer to revert it.

-- 
Duy
Previous: Junio C HamanoNext: Jonathan del Strother
Message 8 of 10 in “git-status segmentation fault in master / OS X”
  1. Jonathan del StrotherJan 19, 2010
  2. Jeff KingJan 20, 2010
  3. Junio C HamanoJan 20, 2010
  4. Jonathan del StrotherJan 20, 2010
  5. Nguyen Thai Ngoc DuyJan 20, 2010
  6. Fix memory corruption when .gitignore does not end by \nNguyễn Thái Ngọc Duy, Jan 20, 2010
  7. Junio C HamanoJan 20, 2010
  8. Nguyen Thai Ngoc DuyJan 21, 2010
  9. Jonathan del StrotherJan 21, 2010
  10. Junio C HamanoJan 21, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.