Re: [PATCH] Fix memory corruption when .gitignore does not end by \n

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 21, 2010, 06:48 UTC
Message-ID: <7vockovtq8.fsf@alter.siamese.dyndns.org>
In-Reply-To: <fcaeb9bf1001201738x5cd374c2o280ec42d6d65c0f7@mail.gmail.com>

Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:

Show 5 quoted lines

> I mean the t3001 patch in comment part, which removes \n at the end of
> .gitignore and crashes the unmodified git.
>
> IOW I found a problem and this patch (not the t3001 one) should fix
> it. Not sure if this causes Jonathan problem though.

Ah, I see. And a bug that leaves a string unterminated will exhibit different symptoms depending on what garbage happens to follow it, so it may not be universally reproducible.

Thanks; applied (and I saw Jonathan's Ack, as well).

Thanks, both.