Re: [RFC/PATCH] t7011: Mark fixed test as such

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Nov 29, 2009, 08:47 UTC
Message-ID: <fcaeb9bf0911290047t43ea3040x730e04baa81d8a98@mail.gmail.com>
In-Reply-To: <0327ed3d7c4621f205d2d111254d716bd1b06c28.1259432535.git.git@drmicha.warpmail.net>

On 11/29/09, Michael J Gruber <git@drmicha.warpmail.net> wrote:

Show 5 quoted lines

> Test 16/17 had been fixed since its introduction in b4d1690 (Teach Git
>  to respect skip-worktree bit (reading part), 2009-08-20). So, mark it as
>  expect_success rather than expect_failure.
>
>  Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>

No ACK. See below.

Show 6 quoted lines

>  ---
>  I'm actually wondering about 17/17 as well.
>  If commit is called with a file name then shouldn't it simply commit the
>  current state of the file in the worktree, no matter what the index or
>  skip-worktree say? I therefore think 17/17 should be expect_success
>  and have no test_must_fail.

Both 16/17 and 17/17 ensure that Git won't look at files on worktree if they are marked as skip-worktree (by definition of skip-worktree, you can safely ignore worktree, otherwise you would not mark them as such). 16/17 happens to pass, not because it does not touch worktree, but because the base index does not have "1", which happens to is the same situation in 16/17 (test commit when "1" is gone). The result is OK but it is actually not (17/17 shows this clearer as it commits the worktree version).

-- 
Duy