git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC/PATCH] t7011: Mark fixed test as such

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Nov 28, 2009, 18:24 UTC
Message-ID
<0327ed3d7c4621f205d2d111254d716bd1b06c28.1259432535.git.git@drmicha.warpmail.net>

Test 16/17 had been fixed since its introduction in b4d1690 (Teach Git to respect skip-worktree bit (reading part), 2009-08-20). So, mark it as expect_success rather than expect_failure.

Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
I'm actually wondering about 17/17 as well.
If commit is called with a file name then shouldn't it simply commit the
current state of the file in the worktree, no matter what the index or
skip-worktree say? I therefore think 17/17 should be expect_success
and have no test_must_fail.
 t/t7011-skip-worktree-reading.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t7011-skip-worktree-reading.sh b/t/t7011-skip-worktree-reading.sh
index e996928..8960dd9 100755
--- a/t/t7011-skip-worktree-reading.sh
+++ b/t/t7011-skip-worktree-reading.sh
@@ -148,7 +148,7 @@ test_expect_success 'git-rm succeeds on skip-worktree absent entries' '
 	git rm 1
 '
 
-test_expect_failure 'commit on skip-worktree absent entries' '
+test_expect_success 'commit on skip-worktree absent entries' '
 	git reset &&
 	setup_absent &&
 	test_must_fail git commit -m null 1
-- 
1.6.6.rc0.274.g71380
Next: Nguyen Thai Ngoc Duy
Message 1 of 6 in “t7011: Mark fixed test as such”
  1. t7011: Mark fixed test as suchMichael J Gruber, Nov 28, 2009
  2. Nguyen Thai Ngoc DuyNov 29, 2009
  3. Michael J GruberNov 29, 2009
  4. Nguyen Thai Ngoc DuyNov 30, 2009
  5. Michael J GruberNov 30, 2009
  6. Nguyen Thai Ngoc DuyNov 30, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.