Re: sparse support in pu

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Aug 17, 2009, 08:17 UTC
Message-ID: <fcaeb9bf0908170117v67e9f8b1ga56edcda14821e91@mail.gmail.com>
In-Reply-To: <2729632a0908162309ma6e7d41kc3bafe4575120630@mail.gmail.com>

On Mon, Aug 17, 2009 at 1:09 PM, <skillzero@gmail.com> wrote:

Show 6 quoted lines

> 1. Have people decided whether it should be on by default if you have
> a .git/info/sparse file? I'd definitely like it to be on by default.
> When I first tried it, I didn't realize I had to use --sparse to git
> checkout to get it to use the sparse rules. The same goes for a merge
> I did that happened to have a file in the excluded area (it included
> it because I didn't use --sparse to git merge).

I tend to make it enabled by default too. I have made it stricter to trigger reading sparse in unpack_trees() -- only do it when unpack_opts.update is TRUE. This should make it safer to be enabled by default.

Show 5 quoted lines

> 2. Is it not hooked up to git reset yet? I did a git checkout --sparse
> and things look liked I expected then I did a git reset --hard
> origin/master and it started checking out all the stuff previously
> excluded via .git/info/sparse. I tried --sparse, but it didn't know
> about that option.

Because sparse was disabled by default, and "git reset" did not enable it. It'd be interesting to see what "git reset --hard" should do in this case: will it apply .git/info/sparse or not, which brings us back to the "default or not" question, hmm..

> 3. One thing that was confusing is that I needed a trailing slash on
> directories in .git/info/sparse to get them excluded. This seems
> different than .gitignore, which works for me without the trailing
> slash.

Hmm.. probably because Git feeds directories to .gitignore handling functions. There is not much I can do, index does not have directories. I don't know if it's worth generating "directories" from index.

-- 
Duy